----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50235/#review143828 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_recovery_tests.cpp (line 822) <https://reviews.apache.org/r/50235/#comment209761> s/ASSERT/EXPECT/ ? src/tests/slave_recovery_tests.cpp (line 1199) <https://reviews.apache.org/r/50235/#comment209760> s/ASSERT/EXPECT/ ? - Vinod Kone On July 20, 2016, 3:07 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50235/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 3:07 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > Check the reason and source of TASK_LOST status updates. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > 79f36a5a855ea1795be83840479e71f0e417298b > src/tests/master_authorization_tests.cpp > e43b264b9f67d4cd965aee143cc42a1034ac9952 > src/tests/master_maintenance_tests.cpp > 2d4b45f78a234118df9e58a69f5587dd4d37956c > src/tests/master_slave_reconciliation_tests.cpp > fdb9bb651c682fb302bb2a533d2dda9bf090839a > src/tests/master_tests.cpp 252b8f9f2740256aaf54f24efe961d49fce53932 > src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 > src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 > > Diff: https://reviews.apache.org/r/50235/diff/ > > > Testing > ------- > > make check > > Also switched a few "ASSERTs" to be "EXPECTs", where I thought that made more > sense. > > > Thanks, > > Neil Conway > >
