----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review143587 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (line 321) <https://reviews.apache.org/r/40266/#comment209410> s/a/an/ 3rdparty/libprocess/src/process.cpp (line 322) <https://reviews.apache.org/r/40266/#comment209411> s/SocketManager/`SocketManager`/ 3rdparty/libprocess/src/process.cpp (line 412) <https://reviews.apache.org/r/40266/#comment209412> s/SocketManager/`SocketManager`/ Perhaps s/wound down/finalized/ to make direct reference to the method that will be used to wind it down? 3rdparty/libprocess/src/process.cpp (line 500) <https://reviews.apache.org/r/40266/#comment209431> s/EventLoop/`EventLoop`/ 3rdparty/libprocess/src/process.cpp (line 1137) <https://reviews.apache.org/r/40266/#comment209735> s/HttpProxy/`HttpProxy`/ 3rdparty/libprocess/src/process.cpp (line 1162) <https://reviews.apache.org/r/40266/#comment209763> Maybe not significant, but perhaps we should reinitialize this to `INADDR_ANY`, since that's the initial value when `__address__` is declared? - Greg Mann On July 14, 2016, 12:21 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40266/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 12:21 a.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3910 > https://issues.apache.org/jira/browse/MESOS-3910 > > > Repository: mesos > > > Description > ------- > > The `SocketManager` and `ProcessManager` are highly inter-dependent, > which requires some untangling in `process::finalize`. > > * Logic originally found in `~ProcessManager` has been split into > `ProcessManager::finalize` due to what happens during cleanup. > * The future from `__s__->accept()` must be explicitly discarded as > libevent does not detect a locally closed socket. > * Terminating `HttpProxy`s must close the associated socket. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 9661386afd4fddd1877d55941fa403afc9230280 > > Diff: https://reviews.apache.org/r/40266/diff/ > > > Testing > ------- > > `make check` (libev) > `make check` (--enable-libevent --enable-ssl) > > > Thanks, > > Joseph Wu > >
