----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/#review143852 -----------------------------------------------------------
Ship it! I'm assuming the `Clock::settle()` is no longer necessary because `AWAIT_*` does Clock::settle() implicitly? Can you add the reason in the description for posterity? Also, I'm guessing you ran these tests in a loop to check for flakiness? - Vinod Kone On July 25, 2016, 9:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50417/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 9:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Remove unnecessary `Clock::settle` calls, whitespace fixes. > > > Diffs > ----- > > src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 > src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 > src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a > > Diff: https://reviews.apache.org/r/50417/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
