----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/#review143989 -----------------------------------------------------------
3rdparty/libprocess/src/socket.cpp (line 108) <https://reviews.apache.org/r/40268/#comment209924> Use `return` directly here? - Greg Mann On July 26, 2016, 9:15 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40268/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 9:15 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3820 > https://issues.apache.org/jira/browse/MESOS-3820 > > > Repository: mesos > > > Description > ------- > > This is needed for tests that utilize the test-only > `process::reinitialize` function. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 881b44b987e5894cac838dae046ab7dbad20b000 > 3rdparty/libprocess/src/socket.cpp 668f26d85cf3097ff9b90a10be14c5833fafd558 > > Diff: https://reviews.apache.org/r/40268/diff/ > > > Testing > ------- > > Some test cleanup issues were uncovered by this change; fixed here: > https://reviews.apache.org/r/40453/ > > > Thanks, > > Joseph Wu > >
