----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50382/#review144024 -----------------------------------------------------------
Ship it! src/tests/hierarchical_allocator_tests.cpp (line 3537) <https://reviews.apache.org/r/50382/#comment209979> Hm.. can we do without this comment? It seems pretty clear to me without the comment. src/tests/hierarchical_allocator_tests.cpp (line 3568) <https://reviews.apache.org/r/50382/#comment209975> s/after filtered out/after filtering/ src/tests/hierarchical_allocator_tests.cpp (line 3723) <https://reviews.apache.org/r/50382/#comment209980> Ditto here. src/tests/hierarchical_allocator_tests.cpp (line 3754) <https://reviews.apache.org/r/50382/#comment209976> s/after filtered out/after filtering/ - Benjamin Mahler On July 25, 2016, 12:29 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50382/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 12:29 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This fix added number of filtered offers to two test cases: > 1) HierarchicalAllocator_BENCHMARK_Test.ResourceLabels > 2) HierarchicalAllocator_BENCHMARK_Test.DeclineOffers > > This can help evaluate how much time does `Resources::contains` > contribute to the time of each allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > bb6947fcecb5b78047e98d10fc1278c612a69548 > > Diff: https://reviews.apache.org/r/50382/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 3100us > Added 1000 agents in 426289us > round 0 allocate() took 295008us to make 0 offers after filtered out 1000 > offers > round 1 allocate() took 261507us to make 0 offers after filtered out 1000 > offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 > (1683 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (1683 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1694 ms total) > [ PASSED ] 1 test. > ``` > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1 > Using 1000 agents and 50 frameworks > Added 50 frameworks in 1722us > Added 1000 agents in 705104us > round 0 allocate() took 568385us to make 1000 offers after filtered out 1000 > offers > round 1 allocate() took 567718us to make 1000 offers after filtered out 2000 > offers > round 2 allocate() took 572209us to make 1000 offers after filtered out 3000 > offers > round 3 allocate() took 584650us to make 1000 offers after filtered out 4000 > offers > round 4 allocate() took 581486us to make 1000 offers after filtered out 5000 > offers > round 5 allocate() took 594665us to make 1000 offers after filtered out 6000 > offers > round 6 allocate() took 608935us to make 1000 offers after filtered out 7000 > offers > round 7 allocate() took 614147us to make 1000 offers after filtered out 8000 > offers > round 8 allocate() took 625020us to make 1000 offers after filtered out 9000 > offers > round 9 allocate() took 631848us to make 1000 offers after filtered out 10000 > offers > round 10 allocate() took 644921us to make 1000 offers after filtered out > 11000 offers > round 11 allocate() took 654093us to make 1000 offers after filtered out > 12000 offers > round 12 allocate() took 661563us to make 1000 offers after filtered out > 13000 offers > round 13 allocate() took 688864us to make 1000 offers after filtered out > 14000 offers > round 14 allocate() took 685055us to make 1000 offers after filtered out > 15000 offers > round 15 allocate() took 703696us to make 1000 offers after filtered out > 16000 offers > round 16 allocate() took 735020us to make 1000 offers after filtered out > 17000 offers > round 17 allocate() took 754733us to make 1000 offers after filtered out > 18000 offers > round 18 allocate() took 769331us to make 1000 offers after filtered out > 19000 offers > round 19 allocate() took 769225us to make 1000 offers after filtered out > 20000 offers > round 20 allocate() took 780541us to make 1000 offers after filtered out > 21000 offers > ... > ``` > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 760us > Added 1000 agents in 566673us > round 0 allocate() took 254148us to make 0 offers after filtered out 1000 > offers > round 1 allocate() took 254993us to make 0 offers after filtered out 1000 > offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 > (1825 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (1825 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1836 ms total) > [ PASSED ] 1 test. > ``` > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1 > Using 1000 agents and 50 frameworks > Added 50 frameworks in 1646us > Added 1000 agents in 866328us > round 0 allocate() took 579024us to make 1000 offers after filtered out 1000 > offers > round 1 allocate() took 590106us to make 1000 offers after filtered out 2000 > offers > round 2 allocate() took 586168us to make 1000 offers after filtered out 3000 > offers > round 3 allocate() took 597511us to make 1000 offers after filtered out 4000 > offers > round 4 allocate() took 598447us to make 1000 offers after filtered out 5000 > offers > round 5 allocate() took 607276us to make 1000 offers after filtered out 6000 > offers > round 6 allocate() took 622511us to make 1000 offers after filtered out 7000 > offers > round 7 allocate() took 630959us to make 1000 offers after filtered out 8000 > offers > round 8 allocate() took 626900us to make 1000 offers after filtered out 9000 > offers > round 9 allocate() took 660346us to make 1000 offers after filtered out 10000 > offers > round 10 allocate() took 684400us to make 1000 offers after filtered out > 11000 offers > round 11 allocate() took 674385us to make 1000 offers after filtered out > 12000 offers > round 12 allocate() took 673139us to make 1000 offers after filtered out > 13000 offers > round 13 allocate() took 690146us to make 1000 offers after filtered out > 14000 offers > round 14 allocate() took 720224us to make 1000 offers after filtered out > 15000 offers > round 15 allocate() took 725789us to make 1000 offers after filtered out > 16000 offers > round 16 allocate() took 736272us to make 1000 offers after filtered out > 17000 offers > round 17 allocate() took 758355us to make 1000 offers after filtered out > 18000 offers > ... > ``` > > > Thanks, > > Guangya Liu > >
