----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50568/#review144028 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources.cpp (line 458) <https://reviews.apache.org/r/50568/#comment209982> Hm.. why isn't this just: ``` result.add(resource); ``` src/v1/resources.cpp (line 460) <https://reviews.apache.org/r/50568/#comment209981> Hm.. why isn't this just: ``` result.add(resource); ``` - Benjamin Mahler On July 28, 2016, 2:03 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50568/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 2:03 p.m.) > > > Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma. > > > Repository: mesos > > > Description > ------- > > This is a follow up action for MESOS-5919. Based on the patch of > https://reviews.apache.org/r/50553/ and > https://reviews.apache.org/r/50557/ , we should update -=/+= to > subtract/add if the resource object is from resources object. > > > Diffs > ----- > > include/mesos/resources.hpp 88a9feabf66ed34e7e5b1c6cb7e831818e7f7883 > include/mesos/v1/resources.hpp 054ed00a03319ae5e350542add34f497eaf79152 > src/common/resources.cpp 3dbff24d6859d3b1ed8589cec50170a5202cfbcb > src/v1/resources.cpp 3c85dc8aa8125962b44e60806ece83a7653d0dc7 > > Diff: https://reviews.apache.org/r/50568/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
