----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50488/#review144217 -----------------------------------------------------------
Ship it! I'll change the description to ``` When the request which contains query parameters is sent to a non-leading master, the master would redirect ignoring the query parameters. This patch changes redirect() to include them. ``` because the fragment is not sent over to the server. src/master/http.cpp (line 2038) <https://reviews.apache.org/r/50488/#comment210217> I'll add a comment when committing. ``` // `request.url` is not absolute so we can safely append it to // `basePath`. See https://tools.ietf.org/html/rfc2616#section-5.1.2 // for details. ``` - Jiang Yan Xu On July 29, 2016, 12:02 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50488/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 12:02 a.m.) > > > Review request for mesos, Adam B, Benjamin Mahler, Jie Yu, Michael Lunøe, > Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-5911 > https://issues.apache.org/jira/browse/MESOS-5911 > > > Repository: mesos > > > Description > ------- > > When the request which contains query parameters or fragment sent to a > non-leading master, the master would redirect to an URL that ignored > the query parameters and fragment. This changes the redirect URL > include the query parameters or fragment. > > > Diffs > ----- > > src/master/http.cpp 1cbec976ccedae81def388c62889624aaf9a794e > > Diff: https://reviews.apache.org/r/50488/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
