> On July 29, 2016, 8:39 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 2581-2589 > > <https://reviews.apache.org/r/50556/diff/1/?file=1456392#file1456392line2581> > > > > The Arithmetic test should contain only the arithemtic operations. We > > can add a 'Filters' or 'Filtering' test that captures methods that perform > > filtering of the resources, like `nonRevocable`, `revocable`, `filter`, etc. > > Guangya Liu wrote: > What about enabling the `filter` test case only include `nonRevocable` > test for now as all of the resources parameters are `nonRevocable` now, the > `nonRevocable` check will hit `add` logic as expected. For `revocable`, as we > do not have such resource types, so it will not hit the `add` logic and would > be pretty fast and cannot evaluate much for the performance. `filter` will be > called by `nonRevocale`, so I think the test case for it will be covered by > `nonRevocable`.
Sounds good, can we call the test 'Filters' or 'Filtering' so that we can add more of the filter functions to it later? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50556/#review144179 ----------------------------------------------------------- On July 28, 2016, 8:51 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50556/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 8:51 a.m.) > > > Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma. > > > Bugs: MESOS-5700 > https://issues.apache.org/jira/browse/MESOS-5700 > > > Repository: mesos > > > Description > ------- > > Added benchmark test for `Resources::nonRevocable`. > > > Diffs > ----- > > src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388 > > Diff: https://reviews.apache.org/r/50556/diff/ > > > Testing > ------- > > make > make check > > ``` > [==========] Running 3 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 > Took 271717us to perform 50000 'total += r' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > Took 1.303957secs to perform 50000 'total.contains(r)' operations on > cpus(*):1; gpus(*):1; mem(*):128; disk(*):256 > Took 526481us to perform 50000 'total -= r' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > Took 968073us to perform 50000 'total = total + r' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > Took 1.270586secs to perform 50000 'total = total - r' operations on > cpus(*):1; gpus(*):1; mem(*):128; disk(*):256 > Took 775512us to perform 50000 'r.nonRevocable()' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (5118 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 > Took 23.026846secs to perform 10 'total += r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 49.498008secs to perform 10 'total.contains(r)' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 24.343378secs to perform 10 'total -= r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 24.444537secs to perform 10 'total = total + r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 24.803728secs to perform 10 'total = total - r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 23.992406secs to perform 10 'r.nonRevocable()' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (170300 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 > Took 2.832429secs to perform 1000 'total += r' operations on ports(*):[1-2, > 4-5, 7-8, 10-11, 13-14, 16-17, 1... > Took 22.034252secs to perform 1000 'total.contains(r)' operations on > ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... > Took 3.628885secs to perform 1000 'total -= r' operations on ports(*):[1-2, > 4-5, 7-8, 10-11, 13-14, 16-17, 1... > Took 3.113548secs to perform 1000 'total = total + r' operations on > ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... > Took 3.854608secs to perform 1000 'total = total - r' operations on > ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... > Took 8.517941secs to perform 1000 'r.nonRevocable()' operations on > ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (43985 > ms) > [----------] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test (219403 > ms total) > > [----------] Global test environment tear-down > [==========] 3 tests from 1 test case ran. (219420 ms total) > [ PASSED ] 3 tests. > ``` > > > Thanks, > > Guangya Liu > >
