> On Aug. 1, 2016, 10:19 a.m., Alexander Rukletsov wrote: > > Thanks a lot for cleaning things up. Could you please test this patch and > > update the "testing done" section? It would be great if you manually create > > some apps with health checks and make sure they work (both succeed and fail > > paths).
Got it, let me fill them. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/#review144317 ----------------------------------------------------------- On Aug. 1, 2016, 1:13 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49555/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 1:13 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-5954 > https://issues.apache.org/jira/browse/MESOS-5954 > > > Repository: mesos > > > Description > ------- > > Updated docker executor to use HealthCheck via library way. > > > Diffs > ----- > > src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e > > Diff: https://reviews.apache.org/r/49555/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
