> On Aug. 1, 2016, 5:14 p.m., Jie Yu wrote: > > Could you please make sure to run some benchmark to validate that there is > > no performance regression. > > Jiang Yan Xu wrote: > Yeah, one of them is /r/50205/ (the Testing Section has numbers for > existing benchmarks which suggests no performance regression) which I'll > commit soon. Of course we should be as thorough as possible, Anindya has more > benchmarks with the allocator too.
Awesome! thank you for doing this! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48616/#review144352 ----------------------------------------------------------- On July 30, 2016, 6:59 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48616/ > ----------------------------------------------------------- > > (Updated July 30, 2016, 6:59 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4892 > https://issues.apache.org/jira/browse/MESOS-4892 > > > Repository: mesos > > > Description > ------- > > Add v1 changes for shared resources. > > > Diffs > ----- > > include/mesos/v1/resources.hpp fdbabf588dc7f7a911d3f37a16511153fd389d8f > src/v1/resources.cpp 230d55b099511499eef111bddd1c552df0093b82 > > Diff: https://reviews.apache.org/r/48616/diff/ > > > Testing > ------- > > > Thanks, > > Anindya Sinha > >
