----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50216/#review144386 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 316) <https://reviews.apache.org/r/50216/#comment210406> s/subcommand/command/ src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 321) <https://reviews.apache.org/r/50216/#comment210407> why we need this? src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 335) <https://reviews.apache.org/r/50216/#comment210408> Put this to the top of the file. src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 355) <https://reviews.apache.org/r/50216/#comment210415> s/mountSandbox/command/ src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 516) <https://reviews.apache.org/r/50216/#comment210416> s/mountVolume/command/ - Jie Yu On July 28, 2016, 7:39 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50216/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 7:39 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang > Yan Xu. > > > Bugs: MESOS-5388 > https://issues.apache.org/jira/browse/MESOS-5388 > > > Repository: mesos > > > Description > ------- > > Updated filesystem linux isolator pre exec commands to be non-shell. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.hpp > 0afe9272900cfa4b39887eb259070a9a2df2ab93 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > db3ed8f69de8b52633194b252b0e5aba38ec69c0 > > Diff: https://reviews.apache.org/r/50216/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh > > > Thanks, > > Gilbert Song > >
