----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50676/#review144419 -----------------------------------------------------------
Ship it! Committing with a minor tweak. src/tests/resources_tests.cpp (lines 2426 - 2427) <https://reviews.apache.org/r/50676/#comment210436> I think this is slightly better. It keeps the 2nd argument together. ``` EXPECT_EQ( 1u, (Resources(nonSharedDisk) + nonSharedDisk).count(nonSharedDisk)); ``` - Jiang Yan Xu On Aug. 1, 2016, 5:33 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50676/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 5:33 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4892 > https://issues.apache.org/jira/browse/MESOS-4892 > > > Repository: mesos > > > Description > ------- > > Resources::count() returns size_t, so the check needs to be for > unsigned integers. > > > Diffs > ----- > > src/tests/resources_tests.cpp 06ccc0c6eb1ed248f1c1ceaedf5a0d85a422b49e > > Diff: https://reviews.apache.org/r/50676/diff/ > > > Testing > ------- > > Tests passed (with `export CXXFLAGS="-Werror=sign-compare"`) > > > Thanks, > > Anindya Sinha > >
