> On Aug. 1, 2016, 5:52 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 135 > > <https://reviews.apache.org/r/50643/diff/1/?file=1458770#file1458770line135> > > > > Just wondering when this method will be called? > > haosdent huang wrote: > When `terminate()`, the `Process` would receive a `TerminateEvent` env, > then this method would be called. > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/process.cpp#L3539-L3542 > > Qian Zhang wrote: > Yeah, I know sending `TerminateEvent` will trigger `finalize()` to be > called. I was just wondering when this event will be sent to > `CgroupsIsolatorProcess`. After checking more code, it seems it will > evetually be triggered when agent is shutdown. Thanks.
Oh, sorry to missunderstand your idea before. The `xxxIsolatorProcess` would `terminate` during the destruction of `isolators` objects. https://github.com/apache/mesos/blob/6ce156b2bed7edecb27ce50f68d262ea4ab4f88e/src/slave/containerizer/mesos/isolator.cpp#L44-L45 - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50643/#review144304 ----------------------------------------------------------- On July 31, 2016, 5:48 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50643/ > ----------------------------------------------------------- > > (Updated July 31, 2016, 5:48 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::finalize`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 422b4653fc3cb3d14c94b93ff456625fc59fbb27 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > bd20631a9650cf84e99c6489b2e92bc40ed764ca > > Diff: https://reviews.apache.org/r/50643/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
