----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50581/#review144459 -----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp (lines 223 - 224) <https://reviews.apache.org/r/50581/#comment210473> I would use 'value' here (a JSON): ``` cout << "Executing pre-exec command " << value << endl; ``` - Jie Yu On Aug. 1, 2016, 11:50 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50581/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 11:50 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > 51f0c110ff0c414837fd69db81047979a0093388 > > Diff: https://reviews.apache.org/r/50581/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh > > The sandbox log will look as the following: > ``` > Executing pre-exec non-shell command > '/home/vagrant/mesos/build/src/mesos-containerizer' with arguments [ > mesos-containerizer, mount, , --help=false, --operation=make-rslave, --path=/ > ] as a subprocess > Executing pre-exec non-shell command 'mount' with arguments [ mount, -n, > --rbind, > /tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutorWithVolumes_CAPegh/slaves/8b348595-e921-4a3b-a7f8-549510982b96-S0/frameworks/8b348595-e921-4a3b-a7f8-549510982b96-0000/executors/f2b0ca11-2747-4e06-a8b2-5afda1438afe/runs/6466b38d-75a2-4e7b-a74a-c49d4cafbf5c, > > /tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutorWithVolumes_CAPegh/provisioner/containers/6466b38d-75a2-4e7b-a74a-c49d4cafbf5c/backends/copy/rootfses/54985528-873a-4999-bbab-dab6e7d914c9/mnt/mesos/sandbox > ] as a subprocess > Executing pre-exec non-shell command 'mount' with arguments [ mount, -n, > --rbind, /tmp/DPe91y/dir1, > /tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutorWithVolumes_CAPegh/provisioner/containers/6466b38d-75a2-4e7b-a74a-c49d4cafbf5c/backends/copy/rootfses/54985528-873a-4999-bbab-dab6e7d914c9/tmp > ] as a subprocess > Executing pre-exec non-shell command 'mount' with arguments [ mount, -n, > --rbind, /tmp/DPe91y/dir2, > /tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutorWithVolumes_CAPegh/provisioner/containers/6466b38d-75a2-4e7b-a74a-c49d4cafbf5c/backends/copy/rootfses/54985528-873a-4999-bbab-dab6e7d914c9/mnt/mesos/sandbox/relative_dir > ] as a subprocess > Changing root to > /tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutorWithVolumes_CAPegh/provisioner/containers/6466b38d-75a2-4e7b-a74a-c49d4cafbf5c/backends/copy/rootfses/54985528-873a-4999-bbab-dab6e7d914c9 > ``` > > > Thanks, > > Gilbert Song > >
