----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50766/#review144668 -----------------------------------------------------------
src/slave/container_loggers/lib_logrotate.hpp (lines 118 - 119) <https://reviews.apache.org/r/50766/#comment210709> `s/synchronous/asynchronous` ? --- `s/should not/does not currently` If someone wants to copy the code and write a derivative module (that, say, uses more threads), they might be tripped up by this wording. src/slave/container_loggers/lib_logrotate.hpp (lines 139 - 147) <https://reviews.apache.org/r/50766/#comment210705> This could be a lambda. (The `validateSize` function is not a lambda because it is called twice.) src/slave/container_loggers/lib_logrotate.cpp (line 96) <https://reviews.apache.org/r/50766/#comment210710> I have a feeling this will emit a warning on some systems (signed/unsigned comparison), but I need to comfirm... - Joseph Wu On Aug. 3, 2016, 1:43 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50766/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 1:43 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-5983 > https://issues.apache.org/jira/browse/MESOS-5983 > > > Repository: mesos > > > Description > ------- > > Defaults to 8 based on the safe default in libprocess itself. > > > Diffs > ----- > > src/slave/container_loggers/lib_logrotate.hpp > 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e > src/slave/container_loggers/lib_logrotate.cpp > d53847bbca83367927725f06e8f962ce7011f468 > > Diff: https://reviews.apache.org/r/50766/diff/ > > > Testing > ------- > > Make check. > Tried changing number of threads. > > > Thanks, > > Joris Van Remoortere > >
