----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50767/#review144672 -----------------------------------------------------------
Fix it, then Ship it! It doesn't compile on Windows just yet, but this does bring it a bit closer :) src/slave/container_loggers/logrotate.hpp (line 21) <https://reviews.apache.org/r/50767/#comment210714> Remove this header. src/slave/container_loggers/logrotate.cpp (line 17) <https://reviews.apache.org/r/50767/#comment210715> Remove this header. - Joseph Wu On Aug. 3, 2016, 1:43 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50767/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 1:43 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This allows for compilation on Windows. > > > Diffs > ----- > > src/slave/container_loggers/lib_logrotate.hpp > 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e > src/slave/container_loggers/logrotate.hpp > 16d92322079a69d8e6bed7830623c62f345cd51c > src/slave/container_loggers/logrotate.cpp > a96cbf1850b484d0dfa2784eb158769512e1f178 > > Diff: https://reviews.apache.org/r/50767/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
