-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50774/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Michael 
Park.


Repository: mesos


Description
-------

Mesos already builds with the `-Wall` and `-Werror` flags.
However, different compilers have different sets of checks for `-Wall`.

This change explicitly adds the `-Wsign-compare` warning flag that is
present in GCC's `-Wall`, but not in Clang.


Diffs
-----

  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 

Diff: https://reviews.apache.org/r/50774/diff/


Testing
-------

Introduced a signed-unsigned comparison on OSX and checked that the build warns 
(fails) due to the comparison.


Thanks,

Joseph Wu

Reply via email to