----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review144725 -----------------------------------------------------------
Another comment is that I found it is difficult to review those patches in such an order, can you please reverse the order of your patch chain? Implement overall logic first, then detail the logic in following patch chain? src/docker/executor.hpp (line 81) <https://reviews.apache.org/r/50125/#comment210789> s/--device/`--device` src/docker/executor.hpp (line 82) <https://reviews.apache.org/r/50125/#comment210790> s/'PathInHost:PathInContainer:Permission'/`PathInHost:PathInContainer:Permission` src/docker/executor.hpp (line 83) <https://reviews.apache.org/r/50125/#comment210791> s/'/dev/tty:/dev/tty:mrw' for '/dev/tty' fully exposed./`/dev/tty:/dev/tty:mrw` for `/dev/tty` fully exposed. src/docker/executor.cpp (line 170) <https://reviews.apache.org/r/50125/#comment210796> remove `` at the end src/docker/executor.cpp (line 171) <https://reviews.apache.org/r/50125/#comment210797> remove period at the end src/docker/executor.cpp (line 827) <https://reviews.apache.org/r/50125/#comment210792> the default value of `string device` is already empty, no need to initialize it. - Guangya Liu On 八月 2, 2016, 2:21 p.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > ----------------------------------------------------------- > > (Updated 八月 2, 2016, 2:21 p.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added a new flag '--device' to mesos-docker-executor, and gave its > feature to control device exposition, isolation, and access permission. > > > Diffs > ----- > > src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 > src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
