----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50621/#review144856 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (line 1201) <https://reviews.apache.org/r/50621/#comment210990> I don't think this `Sequence` is actually used any more - the code which used it seems to have been removed with this commit: https://github.com/apache/mesos/commit/19dfc49fe but we failed to remove `authentications` from `HttpProxy` at that time. - Greg Mann On July 29, 2016, 11:54 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50621/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 11:54 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, > and Vinod Kone. > > > Bugs: MESOS-3910 > https://issues.apache.org/jira/browse/MESOS-3910 > > > Repository: mesos > > > Description > ------- > > Moves the destructor code in `HttpProxy` into the `Process::finalize` > function. And changes the `HttpProxy`s termination logic to > terminate via `UPID` which guards against double-termination. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 7f331b812de2f0437838f48e0959441c8e04c358 > > Diff: https://reviews.apache.org/r/50621/diff/ > > > Testing > ------- > > make > > (More testing doen later in the chain) > > > Thanks, > > Joseph Wu > >
