----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/#review145034 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp (line 37) <https://reviews.apache.org/r/45573/#comment211194> I am not sure why we need this class, can we just put all its logics into `PerfEventSubsystem`? And actually I think we do not need to change anything in perf_event.hpp and perf_event.cpp which should be deleted actually, instead we should directly re-implement their logic in subsystem.hpp and subsystem.cpp as `PerfEventSubsystem` class. So I think we do not need this patch and the work you have done about `PerfEventHandleManager` in https://reviews.apache.org/r/50751, we can only have a single patch (https://reviews.apache.org/r/49853) for `PerfEventSubsystem` just like how you implement other subsystems. - Qian Zhang On Aug. 4, 2016, 1:31 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45573/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 1:31 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5047 > https://issues.apache.org/jira/browse/MESOS-5047 > > > Repository: mesos > > > Description > ------- > > Added `PerfEventHandleManager`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp > 4abde12af68a26b94b3706cdb38bf9890d811039 > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp > 31f35385691681ef5da14be747edfb5f57c5d05a > > Diff: https://reviews.apache.org/r/45573/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
