----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50877/#review145045 -----------------------------------------------------------
Patch looks great! Reviews applied: [50877] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 7, 2016, 10:04 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50877/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2016, 10:04 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This patch is adding more benchmark test cases for sorter include > the following: > > 1) Added time elapse for unallocated all resources for all clients. > 2) Added time elapse for removing all agents. > 3) Added time elapse for removing all clients. > > > Diffs > ----- > > src/tests/sorter_tests.cpp d6578c0df9e860087aa0bc57242b6fc302c7063f > > Diff: https://reviews.apache.org/r/50877/diff/ > > > Testing > ------- > > make > make check > > The result is that the `unallocated` consumed quite a lot of time, the root > cause is that the `contains` is time consuming when `unallocated` resources > for clients. > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*Sorter_BENCHMARK_Test.FullSort/0" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test > [ RUN ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/0 > Using 1000 agents and 1 clients > Added 1 clients in 124us > Added 1000 agents in 29667us > Added allocations for 1000 agents in 81757us > Full sort of 1 clients took 86us > No-op sort of 1 clients took 5us > Removed allocations for 1000 agents in 5.834111secs > Removed 1000 agents in 41694us > Removed 1 clients in 38us > [ OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/0 (5990 ms) > [----------] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test (5990 ms > total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (6012 ms total) > [ PASSED ] 1 test. > ``` > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*Sorter_BENCHMARK_Test.FullSort/35" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test > [ RUN ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35 > Using 50000 agents and 1000 clients > Added 1000 clients in 21453us > Added 50000 agents in 1.572453secs > Added allocations for 50000 agents in 5.358785secs > Full sort of 1000 clients took 32856us > No-op sort of 1000 clients took 347us > Removed allocations for 50000 agents in 5.13780208333333mins > Removed 50000 agents in 1.919385secs > Removed 1000 clients in 21738us > [ OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35 (317208 ms) > [----------] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test (317208 ms > total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (317231 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Guangya Liu > >
