----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/#review145086 -----------------------------------------------------------
Fix it, then Ship it! LGTM (assuming that Alex R's suggestions will be applied) include/mesos/mesos.proto (line 337) <https://reviews.apache.org/r/50812/#comment211277> Ideally this should be an enum, but I guess that we want to be consistent with `message URL`. - Gastón Kleiman On Aug. 5, 2016, 4:19 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50812/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 4:19 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Mahler, and > Gastón Kleiman. > > > Bugs: MESOS-5987 > https://issues.apache.org/jira/browse/MESOS-5987 > > > Repository: mesos > > > Description > ------- > > Updated `HealthCheck` protobuf for HTTP and TCP health check. > > > Diffs > ----- > > include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 > include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 > > Diff: https://reviews.apache.org/r/50812/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
