----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50915/#review145176 -----------------------------------------------------------
Patch looks great! Reviews applied: [50915] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 9, 2016, 4:39 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50915/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2016, 4:39 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5889 > https://issues.apache.org/jira/browse/MESOS-5889 > > > Repository: mesos > > > Description > ------- > > During TearDown of ContainerizerTest<slave::MesosContainerizer>, > we attempt to destroy all cgroups that we can find within the > cgroup root. We observed in CI that on some distributions it > appears that the freeze is not instantaneous and the freezer > delay is needed to complete the destroy process. Howevever, > the clock may be paused at this point which can lead to the > TearDown failing to destroy! > > There does not appear to be a listener hook to run code before > test tear down, so a one-off Clock::resume here seems to be the > simplest route. > > > Diffs > ----- > > src/tests/mesos.cpp 30492d7e3b4c5e9ae9d2b2446cadba62d43a3c65 > > Diff: https://reviews.apache.org/r/50915/diff/ > > > Testing > ------- > > Ran in internal CI on distributions that were seeing this flakiness. > > > Thanks, > > Benjamin Mahler > >
