> On July 22, 2016, 12:32 a.m., Jie Yu wrote: > > src/linux/capabilities.hpp, lines 108-110 > > <https://reviews.apache.org/r/50266/diff/1/?file=1448443#file1448443line108> > > > > No need to for this friend unqulified function. This can just be a > > member function. > > Benjamin Bannier wrote: > I am not sure I follow. This provides a way to insert a > `ProcessCapabilities` into an `ostream` for printing, and I believe this is > the canonical form. If implemented as a member the use would be completely > different (`set.printOn(stream)`?).
Oops. My bad. Didn't realized that `<<` (unlike `+` or `-`) does not allow being defined as a member function. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50266/#review143038 ----------------------------------------------------------- On Aug. 9, 2016, 12:30 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50266/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2016, 12:30 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5051 > https://issues.apache.org/jira/browse/MESOS-5051 > > > Repository: mesos > > > Description > ------- > > This change introduces basic API for linux capabilities. This is not a > comprehensive API but is strictly limited to the need for securing Mesos > containers using linux capabilities. > > This patch is based on the work in https://reviews.apache.org/r/46370/. > > > Diffs > ----- > > src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 > src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 > src/linux/capabilities.hpp PRE-CREATION > src/linux/capabilities.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/50266/diff/ > > > Testing > ------- > > `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o > optimizations) > > > Thanks, > > Benjamin Bannier > >
