----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50736/#review145420 -----------------------------------------------------------
3rdparty/libprocess/src/http.cpp (lines 1373 - 1375) <https://reviews.apache.org/r/50736/#comment211644> It will be cleaner (and easier to read at the call sites) to pass in the `scheme` directly. i.e. `const Option<string>& scheme` Same for below. It's a little unfortunate that the scheme argument will be last, even though it is the front of the URL. But I wouldn't want to go through a big refactor for this change :) - Joseph Wu On Aug. 10, 2016, 3:41 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50736/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 3:41 p.m.) > > > Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-5966 > https://issues.apache.org/jira/browse/MESOS-5966 > > > Repository: mesos > > > Description > ------- > > In order to test libprocess HTTP functionality with SSL > both enabled and disabled, the HTTP helper functions that > libprocess uses in tests must be parametrized by SSL > configuration. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 404196bb198c1ff958b55d72fb29c5fe92dba429 > 3rdparty/libprocess/src/http.cpp 298bd460afdeccd18e201d8a505b961fd4cf3d3e > > Diff: https://reviews.apache.org/r/50736/diff/ > > > Testing > ------- > > Find testing information in the subsequent patch in this chain. > > > Thanks, > > Greg Mann > >
