----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/#review145422 -----------------------------------------------------------
3rdparty/libprocess/src/tests/http_tests.cpp (line 144) <https://reviews.apache.org/r/50737/#comment211647> Per a comment in the previous review, let's change this to `WithParamInterface<string>`. 3rdparty/libprocess/src/tests/http_tests.cpp (line 157) <https://reviews.apache.org/r/50737/#comment211645> This should be `None()` 3rdparty/libprocess/src/tests/http_tests.cpp (line 168) <https://reviews.apache.org/r/50737/#comment211646> `None()` 3rdparty/libprocess/src/tests/http_tests.cpp (lines 181 - 184) <https://reviews.apache.org/r/50737/#comment211648> Per a comment in the previous review, let's change this to `"http"` and `"https"`. - Joseph Wu On Aug. 10, 2016, 3:41 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50737/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 3:41 p.m.) > > > Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-5966 > https://issues.apache.org/jira/browse/MESOS-5966 > > > Repository: mesos > > > Description > ------- > > This patch parametrizes the HTTP tests in libprocess so > that they run with SSL both enabled and disabled when > the library was compiled with SSL support. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > 24b266df5f17e28e0c95326f5d1ea451952500e8 > > Diff: https://reviews.apache.org/r/50737/diff/ > > > Testing > ------- > > Tested on OSX with `GTEST_REPEAT=100 GTEST_BREAK_ON_FAILURE=1 > GTEST_FILTER="*HTTPTest*" 3rdparty/libprocess/libprocess-tests` > > > Thanks, > > Greg Mann > >
