----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50907/#review145437 -----------------------------------------------------------
Fix it, then Ship it! Since you're making the linter object into some sort of interface, you should minimally add comments for object and override-able functions. support/mesos-style.py (lines 11 - 12) <https://reviews.apache.org/r/50907/#comment211666> Would be nice to have a comment here, describing: * General function of the class * What fields/functions to override support/mesos-style.py (lines 43 - 44) <https://reviews.apache.org/r/50907/#comment211668> Would be nice to have a comment here, describing: * When this is called * What the expected arguments are - Joseph Wu On Aug. 8, 2016, 12:49 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50907/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 12:49 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-6006 > https://issues.apache.org/jira/browse/MESOS-6006 > > > Repository: mesos > > > Description > ------- > > Previously, mesos-style.py was just a collection of functions that > checked the style of relevant files in the mesos code base. However, > the script assumed that we always wanted to run cpplint over every > file we were checking. Since we are planning on adding a python linter > to the codebase soon, it makes sense to abstract the common > functionality from this script into a class so that a cpp-based linter > and a python-based linter can inherit the same set of common > functionality. > > This commit builds this abstraction and implements a 'CppLinter()' in > terms of it. > > > Diffs > ----- > > support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 > > Diff: https://reviews.apache.org/r/50907/diff/ > > > Testing > ------- > > Ran `support/mesos-style.py` over the whole code base. > > > Thanks, > > Kevin Klues > >
