----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49351/#review145417 -----------------------------------------------------------
src/docker/executor.cpp (lines 470 - 471) <https://reviews.apache.org/r/49351/#comment211683> This block is for command checks only. Let's prepend it with the comment, why do we need to do extra movements in this case (wrapping command into `docker exec`). src/health-check/health_checker.hpp <https://reviews.apache.org/r/49351/#comment211681> I like your idea to introduce a function per health check type (what you do in r/36816). Do you want to introduce them and do dispatch here? src/health-check/health_checker.cpp (lines 53 - 59) <https://reviews.apache.org/r/49351/#comment211642> Let's extract validation into a separate function/namespace. We can additionally use this function to implement `Option<Error> validateHealthCheck(const HealthCheck& healthCheck);` in the master. I've filed MESOS-6025 for this. - Alexander Rukletsov On Aug. 7, 2016, 6:20 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49351/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2016, 6:20 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2533 > https://issues.apache.org/jira/browse/MESOS-2533 > > > Repository: mesos > > > Description > ------- > > Updated 'HealthCheck' protobuf validation. > > > Diffs > ----- > > src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e > src/health-check/health_checker.hpp > b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 > src/health-check/health_checker.cpp > 585a0b565d948cfa292bad818a710501a4ce0daf > > Diff: https://reviews.apache.org/r/49351/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
