> On Aug. 10, 2016, 7:23 p.m., Benjamin Mahler wrote: > > src/examples/persistent_volume_framework.cpp, lines 402-410 > > <https://reviews.apache.org/r/43558/diff/3/?file=1470240#file1470240line402> > > > > Can you give some context on why lowering these speeds up the test? How > > much does it speed it up?
Hi, @bmahler The most effective snippet is ``` export MESOS_AUTHENTICATION_TIMEOUT=200ms ``` which we committed before. I test this patch again, seems only bring little speed up. Before apply the patch, ``` [ OK ] ExamplesTest.PersistentVolumeFramework (3505 ms) [----------] 1 test from ExamplesTest (3510 ms total) ``` After apply the patch, ``` [ OK ] ExamplesTest.PersistentVolumeFramework (2493 ms) [----------] 1 test from ExamplesTest (2497 ms total) ``` Do you think we should discard this? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/#review145390 ----------------------------------------------------------- On Aug. 10, 2016, 5:21 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43558/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 5:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jie Yu. > > > Bugs: MESOS-4663 > https://issues.apache.org/jira/browse/MESOS-4663 > > > Repository: mesos > > > Description > ------- > > Speed up ExamplesTest.PersistentVolumeFramework. > > > Diffs > ----- > > src/examples/persistent_volume_framework.cpp > fe2837cfffb6dd251ccb9c93197f623d0c55fb36 > > Diff: https://reviews.apache.org/r/43558/diff/ > > > Testing > ------- > > Repeat test in CentOS 7.1 > ``` > sudo ./bin/mesos-tests.sh > --gtest_filter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 > --gtest_break_on_failure > ``` > > > Thanks, > > haosdent huang > >
