> On Aug. 10, 2016, 7:21 p.m., Vinod Kone wrote: > > src/Makefile.am, line 2263 > > <https://reviews.apache.org/r/50914/diff/2/?file=1469120#file1469120line2263> > > > > this should be deleted as well. this is causing the ASF CI to fail. > > Vinod Kone wrote: > I pushed the fix.
Thanks vinod. Some how this is not exposed in our own CI :( - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50914/#review145389 ----------------------------------------------------------- On Aug. 9, 2016, 8:12 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50914/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2016, 8:12 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-3370 > https://issues.apache.org/jira/browse/MESOS-3370 > > > Repository: mesos > > > Description > ------- > > Removed the external containerizer. > > > Diffs > ----- > > configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 > docs/committers.md a4cf837e3058686347bc721dc7f0745f88c4fa81 > docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 > docs/containerizer-internals.md 1839c7290c2c7681c516b3514face7496ffb2521 > docs/external-containerizer.md eece9e73d47c13cc50074ef77235147f09cd380a > docs/fetcher.md 688984552ae243eb59a3c1bfb7abd3898e4fac67 > docs/home.md 80451f4a9b2327dc728b9454938b6205043bebbb > docs/sandbox.md db973e311b8562aa25fcdcdabefa1f342d25e26e > include/mesos/containerizer/containerizer.proto > 4d8e82791c263c6578bf06f4e94ebe853042be59 > src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 > src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 > src/examples/python/test-containerizer.in > 5066b45d11ce0418d6c8ae8374b5103cb0eaa249 > src/examples/python/test_containerizer.py > 8e154b0e8e0db3cfc5d3f695d509b0e49bcec652 > src/slave/containerizer/containerizer.cpp > ba3b3f62fe0cf755fdbebf52350d9069cb2efca8 > src/slave/containerizer/external_containerizer.hpp > feeb0278a3d8fec8c7177a9a3dc443ee0c198c5c > src/slave/containerizer/external_containerizer.cpp > 9ee137a7731e66754bbf86424071765962423969 > src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 > src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 > src/tests/containerizer/external_containerizer_test.cpp > 226eac56725e908040abda306a2e5e3c96bce9d7 > > Diff: https://reviews.apache.org/r/50914/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
