-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
-----------------------------------------------------------
(Updated Aug. 11, 2016, 6:32 p.m.)
Review request for mesos, Alexander Rukletsov and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335
Repository: mesos
Description
-------
Fully-typed all FlagsBase::add overloads.
Diffs (updated)
-----
3rdparty/stout/include/stout/flags.hpp
bc4684d499bad6e409953f608330325c4a13d6a6
3rdparty/stout/include/stout/flags/flags.hpp
4ca6c69aeb1e3343e9b0ae2562c450c4c645890c
3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b
3rdparty/stout/tests/subcommand_tests.cpp
9213d6b9faec30b5be320ab37ca29c2406c964ac
Diff: https://reviews.apache.org/r/46825/diff/
Testing
-------
make check (OS X clang-trunk w/o optimizations)
The mesos tests suite do not execute at all with an optimizing clang-trunk
since copying of the `map` inside `FlagsBase` reference random memory leading
to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests`
can be executed, but some remaining failures persist in `mesos-tests` (their
number is reduced though).
Thanks,
Benjamin Bannier
