----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50994/#review145529 -----------------------------------------------------------
I think we need to update `launchHealthCheck` in `src/docker/executor.cpp` as well. But I feel it would better to update it when adding HTTP health check and do it in a sperate patch. - haosdent huang On Aug. 11, 2016, 5:35 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50994/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 5:35 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Bugs: MESOS-6025 > https://issues.apache.org/jira/browse/MESOS-6025 > > > Repository: mesos > > > Description > ------- > > Updated 'HealthCheck' protobuf validation. > > > Diffs > ----- > > src/health-check/health_checker.hpp > 7bc345bbc835f31feb2114cba434ab544451dbb0 > src/health-check/health_checker.cpp > d43cb0568c120cbcec6a73d232396ccc54cf3e58 > src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 > src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c > src/tests/health_check_tests.cpp 3b44d80fd079f216896f9386fb22d518061938ab > > Diff: https://reviews.apache.org/r/50994/diff/ > > > Testing > ------- > > Test via `sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*HealthCheckTest*" --verbose` > > > Thanks, > > haosdent huang > >
