----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51041/#review145643 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Aug. 12, 2016, 4:47 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51041/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 4:47 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Compilers can typically warn about enum values not handled in a > `switch`. If one adds a `default` case, even if the enum is extended > later, all cases will already be covered. > > Instead do not use a `default` case so that we are warned whenever the > definition of the enum and our pattern matching against its value get > out of sync. > > > Diffs > ----- > > src/linux/capabilities.cpp 5f21dd42dd94af907450aabb1900d1f73816b31c > > Diff: https://reviews.apache.org/r/51041/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Bannier > >
