----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50994/#review145675 -----------------------------------------------------------
src/health-check/health_checker.cpp (line 296) <https://reviews.apache.org/r/50994/#comment212018> How about: "Expecting 'command' to be set for command health check" src/health-check/health_checker.cpp (line 305) <https://reviews.apache.org/r/50994/#comment212022> "Command health check should specify either 1 or 2" src/health-check/health_checker.cpp (line 309) <https://reviews.apache.org/r/50994/#comment212019> How about: "Expecting 'http' to be set for HTTP health check" src/health-check/health_checker.cpp (line 321) <https://reviews.apache.org/r/50994/#comment212023> `!strings::startsWith()`? src/health-check/health_checker.cpp (line 327) <https://reviews.apache.org/r/50994/#comment212020> How about: "Expecting 'tcp' to be set for TCP health check" - Alexander Rukletsov On Aug. 12, 2016, 11:16 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50994/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 11:16 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón > Kleiman. > > > Bugs: MESOS-6025 > https://issues.apache.org/jira/browse/MESOS-6025 > > > Repository: mesos > > > Description > ------- > > Added 'HealthCheck' protobuf validation. > > > Diffs > ----- > > src/health-check/health_checker.hpp > 7bc345bbc835f31feb2114cba434ab544451dbb0 > src/health-check/health_checker.cpp > d43cb0568c120cbcec6a73d232396ccc54cf3e58 > src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 > src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c > src/tests/health_check_tests.cpp 3b44d80fd079f216896f9386fb22d518061938ab > > Diff: https://reviews.apache.org/r/50994/diff/ > > > Testing > ------- > > Test via `sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*HealthCheckTest*" --verbose` > > > Thanks, > > haosdent huang > >
