----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50996/#review145678 -----------------------------------------------------------
Fix it, then Ship it! I'll fix and commit shortly. src/health-check/health_checker.cpp (line 302) <https://reviews.apache.org/r/50996/#comment212026> We can add here checks similar to what you've added for `_commandHealthCheck()`. src/health-check/health_checker.cpp (line 308) <https://reviews.apache.org/r/50996/#comment212027> We can add here checks similar to what you've added for `_commandHealthCheck()`. - Alexander Rukletsov On Aug. 12, 2016, 11:49 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50996/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 11:49 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón > Kleiman. > > > Repository: mesos > > > Description > ------- > > Dispatched health check by type. > > > Diffs > ----- > > src/health-check/health_checker.hpp > 7bc345bbc835f31feb2114cba434ab544451dbb0 > src/health-check/health_checker.cpp > d43cb0568c120cbcec6a73d232396ccc54cf3e58 > > Diff: https://reviews.apache.org/r/50996/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
