----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51039/#review145679 -----------------------------------------------------------
Fix it, then Ship it! src/docker/executor.cpp (line 484) <https://reviews.apache.org/r/51039/#comment212028> Backticks, please. src/docker/executor.cpp (lines 494 - 496) <https://reviews.apache.org/r/51039/#comment212033> This is not entirely correct, because we are going to run HTTP health checks not via `docker exec` (we'll be using `setns`). - Alexander Rukletsov On Aug. 12, 2016, 11:52 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51039/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 11:52 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón > Kleiman. > > > Bugs: MESOS-6025 > https://issues.apache.org/jira/browse/MESOS-6025 > > > Repository: mesos > > > Description > ------- > > Updated 'HealthCheck' protobuf validation in docker executor. > > > Diffs > ----- > > src/docker/executor.cpp 4c08e5d589a64be21fd2396cf575694b126a15c2 > > Diff: https://reviews.apache.org/r/51039/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
