----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51091/#review145757 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 87 - 91) <https://reviews.apache.org/r/51091/#comment212117> Do we really need this? I think we have already guaranteed this in `MesosContainerizer::create()`, so if there is anything wrong in `--isolation` (e.g., `cgroups/xyz`), it must have been detected in `MesosContainerizer::create()`, right? If it is really needed, maybe we should do it as `CHECK(isolatorMap.contains(isolator))`? - Qian Zhang On Aug. 15, 2016, 9:07 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51091/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 9:07 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Repository: mesos > > > Description > ------- > > Disallowed unknown cgroups isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 7e205a3eea4ad89faccf564bdb2ad0041fdee249 > > Diff: https://reviews.apache.org/r/51091/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
