----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51099/#review145780 -----------------------------------------------------------
src/common/values.cpp (line 72) <https://reviews.apache.org/r/51099/#comment212145> You should also update `v1/values.cpp`. src/common/values.cpp (line 74) <https://reviews.apache.org/r/51099/#comment212141> `stream.precision(int)` returns the previous value, so you only need to call it twice in total, not three times. src/tests/resources_tests.cpp (line 882) <https://reviews.apache.org/r/51099/#comment212144> Wouldn't hurt to have another test case that is even larger, IMO. - Neil Conway On Aug. 15, 2016, 5:54 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51099/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 5:54 p.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-5875 > https://issues.apache.org/jira/browse/MESOS-5875 > > > Repository: mesos > > > Description > ------- > > Also clarified in the comments that when we say "We discard any additional > precision" we mean the fractional part. > > > Diffs > ----- > > src/common/values.cpp cc87d9436f1a75e71cbeb8b709ec323e24f4f519 > src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b > > Diff: https://reviews.apache.org/r/51099/diff/ > > > Testing > ------- > > make check. > > Added a test block which would fail without the change. > > > Thanks, > > Jiang Yan Xu > >
