----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/#review145965 -----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (line 1018) <https://reviews.apache.org/r/50750/#comment212320> Why removed `create` here? I think this test will also cover the `create()` method of `NetClsSubsystem`, right? src/tests/containerizer/isolator_tests.cpp (line 1024) <https://reviews.apache.org/r/50750/#comment212321> s/CgroupsIsolator/CgroupsIsolatorProcess/ s/cleans/clean/ src/tests/environment.cpp (line 438) <https://reviews.apache.org/r/50750/#comment212323> Here can we change it to the following? ``` if (matches(test, "ROOT_CGROUPS_Isolate") || matches(test, "ROOT_CGROUPS_ContainerStatus") { ``` In this way, I think you can still name the test class as `CgroupsIsolatorTest` which will be consistent with other cgroup's related tests. - Qian Zhang On Aug. 17, 2016, 1:47 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50750/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 1:47 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5976 > https://issues.apache.org/jira/browse/MESOS-5976 > > > Repository: mesos > > > Description > ------- > > Removed CgroupsNetClsIsolatorProcess. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/containerizer.cpp > 5ed894d18258f6516866a2acd343c03281039c3c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b3fd8c85476bf46368bd79f052b7923ad9d32199 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > bebefbba7153d4b0e9a8d7179cfb642e6e802bea > src/tests/containerizer/isolator_tests.cpp > f917db78157f799efc00b0c7af0230ddb6f26b0b > src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 > > Diff: https://reviews.apache.org/r/50750/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
