----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51265/#review146265 -----------------------------------------------------------
Fix it, then Ship it! I did some editing on the comments. src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 264 - 268) <https://reviews.apache.org/r/51265/#comment212648> Ditto. Let's not introduce this yet. src/slave/containerizer/mesos/isolators/gpu/isolator.cpp <https://reviews.apache.org/r/51265/#comment212647> I'll do this change later. There are more places that we need to clean up. - Jie Yu On Aug. 21, 2016, 9:29 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51265/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 9:29 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-6059 > https://issues.apache.org/jira/browse/MESOS-6059 > > > Repository: mesos > > > Description > ------- > > When the container have not finished successfully in > `MesosContainerizerProcess::prepare` or > `MesosContainerizerProcess::recover` successfully, this container may > by unknown to some isolators or some subsystems. So we should allow > clean up unknown containers in `Isolator::cleanup` and > `Subsystem::cleanup`. > > > Diffs > ----- > > include/mesos/slave/isolator.hpp b90974e67ca69adfdc8198529d4ca8629da3dfca > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 0c724523a8b46f74a52214ae2b223f41f8dc2d58 > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp > 06f4400966ba467623556901b38d12e69fbbbd04 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp > 3b25df2fcbb412ecb0140413f61aee85ecdd2b56 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > af427c6e5691f1770ab3ebef79502eb2c2176c4a > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > 1383ba2dbb2be99b3eca0f2f62386438827e0bd6 > > Diff: https://reviews.apache.org/r/51265/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
