----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51195/#review146334 -----------------------------------------------------------
src/tests/CMakeLists.txt (line 36) <https://reviews.apache.org/r/51195/#comment212706> Please add a link dep on libmesos like you did for the automake setup (I believe you need to depend on `MESOS_TARGET`). src/tests/active_user_test_helper.hpp (line 19) <https://reviews.apache.org/r/51195/#comment212713> Please include also `stout/flags/flags.hpp` for `flags::FlagsBase`. src/tests/cmake/MesosTestsConfigure.cmake (line 24) <https://reviews.apache.org/r/51195/#comment212708> I do not understand why we need a cached variable here, moreover one which is not set as `INTERNAL`. I believe just a normal variable would be good enough. It seems this is in line with what is already used elsewhere in the cmake build, but that does not make it more reasonable. src/tests/test_helper_main.cpp (line 17) <https://reviews.apache.org/r/51195/#comment212707> Please include `stout/none.hpp`. - Benjamin Bannier On Aug. 18, 2016, 6:53 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51195/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 6:53 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-6053 > https://issues.apache.org/jira/browse/MESOS-6053 > > > Repository: mesos > > > Description > ------- > > Refactored the test helper to use a single binary. > > > Diffs > ----- > > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/tests/CMakeLists.txt 1ea8b2102753ae294bd75706ffaf08308e928acd > src/tests/active_user_test_helper.hpp PRE-CREATION > src/tests/active_user_test_helper.cpp > 54e866899f650abb3be9140a8aed3f83918a7cf6 > src/tests/cmake/MesosTestsConfigure.cmake > 361032082c3a5f76b949dc7981f75b53e02d84f5 > src/tests/slave_tests.cpp 30ca3da6ca2f1e068bb3f8a6abc7efeebd5bfe8c > src/tests/test_helper_main.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51195/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
