----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51248/#review146328 -----------------------------------------------------------
src/master/validation.hpp (line 80) <https://reviews.apache.org/r/51248/#comment212701> I saw that many comments are saying that those are `only exposed for testing.`, but they are actully used in source code but not test. src/master/validation.cpp (lines 473 - 474) <https://reviews.apache.org/r/51248/#comment212735> Can we make this less jagged? ``` // Validates that revocable and non-revocable // resource of the same name do not exist. ``` src/master/validation.cpp (lines 603 - 604) <https://reviews.apache.org/r/51248/#comment212737> Ditto as above to make this less jagged. ``` // Master ensures `ExecutorInfo.framework_id` // is set before calling this method. ``` src/master/validation.cpp (line 635) <https://reviews.apache.org/r/51248/#comment212739> kill this src/master/validation.cpp (line 640) <https://reviews.apache.org/r/51248/#comment212741> ``` const Resources& resources = executor.resources(); ``` src/master/validation.cpp (line 751) <https://reviews.apache.org/r/51248/#comment212742> kill this src/master/validation.cpp (line 897) <https://reviews.apache.org/r/51248/#comment212745> ``` const Resources& resources = executor.resources(); ``` - Guangya Liu On 八月 21, 2016, 11:28 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51248/ > ----------------------------------------------------------- > > (Updated 八月 21, 2016, 11:28 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6042 > https://issues.apache.org/jira/browse/MESOS-6042 > > > Repository: mesos > > > Description > ------- > > Refactored in such a way that most of the helper functions can be > reused for doing task group validation. > > Note that there are no functional changes here only code movement. > > > Diffs > ----- > > src/master/validation.hpp fd00609df483930d9f749ce764830129da9e8a2c > src/master/validation.cpp ddc7ac3965c93138a38fe3c79776173c610393d6 > src/tests/master_validation_tests.cpp > ad89812a55fa56c2e13e2a683e35f777dc6341a9 > > Diff: https://reviews.apache.org/r/51248/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
