----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51270/#review146356 -----------------------------------------------------------
src/master/validation.hpp (line 123) <https://reviews.apache.org/r/51270/#comment212758> Why does this `only exposed for testing.`? I saw that those APIs are not used for testing but doing some validation when launching task groups. src/master/validation.cpp (line 1016) <https://reviews.apache.org/r/51270/#comment212756> s/.get()./-> Ditto for others src/master/validation.cpp (line 1053) <https://reviews.apache.org/r/51270/#comment212750> ``` const Resources& resources = executor.resources(); ``` src/master/validation.cpp (line 1116) <https://reviews.apache.org/r/51270/#comment212754> kill this - Guangya Liu On 八月 21, 2016, 11:29 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51270/ > ----------------------------------------------------------- > > (Updated 八月 21, 2016, 11:29 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6042 > https://issues.apache.org/jira/browse/MESOS-6042 > > > Repository: mesos > > > Description > ------- > > The TaskGroup is considered invalid if any of the tasks or the executor > is invalid. > > > Diffs > ----- > > src/master/validation.hpp fd00609df483930d9f749ce764830129da9e8a2c > src/master/validation.cpp ddc7ac3965c93138a38fe3c79776173c610393d6 > src/tests/master_validation_tests.cpp > ad89812a55fa56c2e13e2a683e35f777dc6341a9 > > Diff: https://reviews.apache.org/r/51270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
