-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51009/#review146387
-----------------------------------------------------------




src/slave/containerizer/docker.cpp (line 1823)
<https://reviews.apache.org/r/51009/#comment212793>

    There is a mesos-style rule at 
https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#empty-lines
    
    >Inside a code block, every multi-line statement should be followed by one 
empty line.
    
    So we need add a following empty line here. XD


- haosdent huang


On Aug. 11, 2016, 10:17 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51009/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 10:17 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, Gilbert Song, Jie Yu, and Steve 
> Niemitz.
> 
> 
> Bugs: MESOS-6031
>     https://issues.apache.org/jira/browse/MESOS-6031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Collect throttle related cpu.stat for Docker Containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
> 
> Diff: https://reviews.apache.org/r/51009/diff/
> 
> 
> Testing
> -------
> 
> Run agent with cfs quota enabled, and observe that throttle related metrics 
> are in `/containers` and `/monitoring/statistics`
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to