> On Aug. 22, 2016, 7:37 p.m., Gilbert Song wrote: > > include/mesos/slave/isolator.proto, lines 151-158 > > <https://reviews.apache.org/r/51263/diff/2/?file=1480457#file1480457line151> > > > > Should we update the index numbers?
Nope. Not necessary. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51263/#review146412 ----------------------------------------------------------- On Aug. 22, 2016, 4:40 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51263/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 4:40 a.m.) > > > Review request for mesos and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > `containerizer::Termination` is a legacy protobuf for external > containerizer. Since we already removed the external containerizer, this > patch renamed it to `ContainerTermination` and moved the definition to > `containerizer.proto`. This patch also moved all definitions in > `isolator.proto` to `containerizer.proto` to be more consistent. > > > Diffs > ----- > > include/mesos/containerizer/containerizer.hpp > 01b1bface5d51e247c8ede65f4766cfcbee32320 > include/mesos/containerizer/containerizer.proto > 7c35ef38b0aa38591513a5be066a769f31825332 > include/mesos/slave/isolator.hpp ea1fa4fa72940b1f5f1e23884f263008afc3d9d9 > include/mesos/slave/isolator.proto e945514fbdd49b3b35e200a7fc2e1cd446c1af91 > src/CMakeLists.txt 7ffe377aa1b6e726c964f7b9f0f4ea067d8fddf9 > src/Makefile.am 83db8829aa51eed08daa81d0064034f385c5b95a > src/slave/containerizer/composing.hpp > 406015a8b102a6889eba64fc1267585b8c76f2d1 > src/slave/containerizer/composing.cpp > c51cb4b4753a6644650eec24e643884785003466 > src/slave/containerizer/containerizer.hpp > bf39aaaf4de5e110989a94bb993fd39b7a611ac7 > src/slave/containerizer/docker.hpp 6597d86322eff67153d359cb72e9e5700ef067a0 > src/slave/containerizer/docker.cpp e447c58bd46ba080529e8f349347eccf5a54110a > src/slave/containerizer/mesos/containerizer.hpp > 499396121de4e9e654f78f73493e76053fb83d42 > src/slave/containerizer/mesos/containerizer.cpp > 77a502f853e3e04ea8e274419544601778be9421 > src/slave/slave.hpp 9f29d80182210357e0b85d8c69e9fd7e46ef94f2 > src/slave/slave.cpp 3688f420e71ce9c79b7dda221f3f5c0042a9b3a1 > src/tests/cluster.cpp dd415446a89f1a398df0396afc247621ebc90c9f > src/tests/containerizer.hpp cd7eeb00a3c846427f9e41ac1cc5b34ce741dd85 > src/tests/containerizer.cpp 761b1edcc592dd54c04ef199562babcb830ec2a5 > src/tests/containerizer/composing_containerizer_tests.cpp > 5a9d5e4b3c7a7632557fbcdbe03f7e2d7db3e55b > src/tests/containerizer/docker_containerizer_tests.cpp > 42d4364b6fcbc94c7852721511001c103cb5a90d > src/tests/containerizer/filesystem_isolator_tests.cpp > 2b216c3fd2cf01b8b43a262795257ae65af8af2f > src/tests/containerizer/isolator_tests.cpp > 05620d2411d464593cdb5aeaea10cb147047569b > src/tests/containerizer/mesos_containerizer_tests.cpp > 4a49247a8b8c6995535a865266f85f2aa31fb4de > src/tests/containerizer/port_mapping_tests.cpp > fd181cae5540de1fdd631367aba5cce249f1b72c > src/tests/health_check_tests.cpp e69c4f5cc4756f4926e67ce5e9bbd7ab17e41913 > src/tests/hook_tests.cpp ac1188e29ca513e99b7a4b8b633cb8ee86469230 > src/tests/slave_recovery_tests.cpp b6d4ae54e327ece18263e11cb7ca01fb832a5da4 > > Diff: https://reviews.apache.org/r/51263/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
