----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51262/#review146455 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 1123) <https://reviews.apache.org/r/51262/#comment212896> just nit: I think we should avoid using integers as booleans in favor of explicitly checking the condition we care about. I posted a patch weeks ago for this and also made an update today to fix here: https://reviews.apache.org/r/50423/ - Guangya Liu On 八月 22, 2016, 4:40 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51262/ > ----------------------------------------------------------- > > (Updated 八月 22, 2016, 4:40 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-6057 > https://issues.apache.org/jira/browse/MESOS-6057 > > > Repository: mesos > > > Description > ------- > > This addressed MESOS-6057. Isolator generated environment variables > should be overwritten by user specified env variables. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 77a502f853e3e04ea8e274419544601778be9421 > > Diff: https://reviews.apache.org/r/51262/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
