-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51027/
-----------------------------------------------------------
(Updated Aug. 23, 2016, 8:32 a.m.)
Review request for mesos, Benjamin Mahler, James Peach, Klaus Ma, and Jiang Yan
Xu.
Changes
-------
Adding back reviewers and dependencies.
Bugs: MESOS-3157
https://issues.apache.org/jira/browse/MESOS-3157
Repository: mesos
Description (updated)
-------
- Triggered allocations dispatch allocate() only
if there is no pending allocation in the queue.
- Allocation candidates are accumulated and only
cleared when enqueued allocations are processed.
- Batched allocations are handled synchronously.
- Carrying over work from https://reviews.apache.org/r/41658/ and added the
previous reviewers
- Specifically, this patch introduces the boolean flag pendingAllocation, which
when set on event
triggered allocations, will prevent additional no-op allocations: the flag is
cleared when
the enqueued allocation is processed, subsequent event triggered allocations
will update a set
of allocation candidates rather than dispatching an additional allocate().
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp
bdbc6d3b5b959990538f4e3b7b1a3b031d9aea05
src/master/allocator/mesos/hierarchical.cpp
234ef98529964a0b6d3f132426a6c8ccbb1263ee
Diff: https://reviews.apache.org/r/51027/diff/
Testing
-------
make check
note: check without filters depends on https://reviews.apache.org/r/51028
With new benchmark https://reviews.apache.org/r/49617:
Sample output without 51027:
[ RUN ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
Using 10000 agents and 3000 frameworks
Added 3000 frameworks in 57251us
Added 10000 agents in 3.21345353333333mins
allocator settled after 1.61236038333333mins
[ OK ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
(290578 ms)
Sample output with 51027:
[ RUN ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
Using 10000 agents and 3000 frameworks
Added 3000 frameworks in 39817us
Added 10000 agents in 3.22860541666667mins
allocator settled after 25.525654secs
[ OK ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
(220137 ms)
Thanks,
Jacob Janco
