----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51317/#review146562 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp (line 3366) <https://reviews.apache.org/r/51317/#comment213065> `_accept()` - Vinod Kone On Aug. 23, 2016, 5:11 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51317/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 5:11 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The use of `pendingTasks` cannot distinguish between a duplicate > TaskID and a task that has been killed while pending. This means > that if an invalid or unauthorized task is killed while pending, > TASK_KILLED is sent, and once in Master::_accept, we will also > send TASK_ERROR. > > > Diffs > ----- > > src/master/master.cpp d94a8510c4cee9c010706f79caf27ef4a10b41a8 > > Diff: https://reviews.apache.org/r/51317/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Mahler > >
