----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/#review146649 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/posix/executor.cpp (lines 97 - 98) <https://reviews.apache.org/r/51266/#comment213215> Let's rephrase a bit. How about: Ensure that mount namespace of the executor is not affected by changes in its task's namespace, e.g. pivot_root called as part of the task setup in mesos-containerizer binary. - Alexander Rukletsov On Aug. 21, 2016, 6:42 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51266/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 6:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > When launching mesos-containerizer in the mesos-executor, we need to > ensure mesos-executor unshare the mount namespace with > mesos-containerizer. Otherwise, the mount and pivot_root operations in > mesos-containerizer would affect the running context of > mesos-executor. > > > Diffs > ----- > > src/launcher/posix/executor.cpp 43573cacee4e681d4327a7ed7c43b4ee263aa175 > > Diff: https://reviews.apache.org/r/51266/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
