----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51210/#review146708 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp (lines 128 - 130) <https://reviews.apache.org/r/51210/#comment213274> s/const/constexpr/ I think there's little difference here, but we use `constexpr` for these string constants in other locations. - Joseph Wu On Aug. 18, 2016, 11:08 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51210/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 11:08 a.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Update mesos-executor name for Windows. > > > Diffs > ----- > > src/slave/slave.cpp 3688f420e71ce9c79b7dda221f3f5c0042a9b3a1 > > Diff: https://reviews.apache.org/r/51210/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
